Skip to content

test: Add test coverage for ChatClientObservationContext #4124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Aug 12, 2025

Adds new test cases for ChatClientObservationContext to improve validation and edge case coverage.

Tests Added

  • Null request/prompt validation
  • Advisor list handling (valid, empty, defensive copying)
  • Builder pattern behavior
  • Request reference integrity
  • Default advisor behavior

Impact

  • Improves null safety validation
  • Ensures proper advisor collection handling
  • Validates builder reuse scenarios

Co-authored-by: Oleksandr Klymenko <[email protected]>
Signed-off-by: Oleksandr Klymenko <[email protected]>
@sobychacko sobychacko added this to the 1.1.0.M1 milestone Aug 13, 2025
@sobychacko sobychacko merged commit 9274531 into spring-projects:main Aug 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants